Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

making local alsa properly optional #3756

Merged
merged 6 commits into from
May 1, 2024
Merged

making local alsa properly optional #3756

merged 6 commits into from
May 1, 2024

Conversation

judovana
Copy link
Contributor

@judovana judovana commented Apr 9, 2024 •
edited
Loading

This pr is dong two things (afaik so connected that should be together)

  • first commit judovana@5f0b38f is fixing issue, when alsa was donwloaded and unpacked, but it was not used. The usage was for jdk8 only. If it was intentional then I will rework this.
  • second commit judovana@f2afb6e is making the download of alsa optional. If not downloaded, then the system alsa will be used, or user will specify theirs.

The second commit + my old #3737 should be enough for offline build.

related to #3752

@judovana
Copy link
Contributor Author

judovana commented Apr 9, 2024 •
edited
Loading

I admit I had made an fundamental build change, but Still I was not expecting build failures. In addition, they do not look related.... /me confused ..even windows...

edit: Those are future jdk-head only, and do not seem indeed related (but second eye would be awesome!)

@judovana
Copy link
Contributor Author

ping please?

github-actions[bot]
github-actions bot previously requested changes Apr 22, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

karianna
karianna requested changes Apr 23, 2024
View reviewed changes
sbin/common/config_init.sh Show resolved Hide resolved
sbin/prepareWorkspace.sh Outdated Show resolved Hide resolved
sbin/build.sh Show resolved Hide resolved
makejdk-any-platform.1 Outdated Show resolved Hide resolved
judovana and others added 2 commits April 23, 2024 13:33
@judovana
Copy link
Contributor Author

tyvm!

@judovana
Copy link
Contributor Author

@andrew-m-leonard @sxa Thoughts?

@andrew-m-leonard
Copy link
Contributor

/thaw

@github-actions github-actions bot dismissed their stale review April 26, 2024 07:49

Pull Request unblocked - code freeze is over.

andrew-m-leonard
andrew-m-leonard approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks Jiri

@andrew-m-leonard andrew-m-leonard merged commit 48a734d into adoptium:master May 1, 2024
23 checks passed
@judovana
Copy link
Contributor Author

judovana commented May 1, 2024

tyvm!

/integrate

@andrew-m-leonard andrew-m-leonard mentioned this pull request May 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karianna karianna karianna approved these changes

@andrew-m-leonard andrew-m-leonard andrew-m-leonard approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@judovana @andrew-m-leonard @karianna