-
-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update code freeze bot to check target PR branch correctly for issue_comment #3770
Conversation
…comment Signed-off-by: Andrew Leonard <[email protected]>
…comment Signed-off-by: Andrew Leonard <[email protected]>
comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.
If this pull request needs to be merged during the release cycle then please comment /merge
and a PMC member will be able to remove the block.
If the code freeze is over you can remove this block by commenting /thaw
.
/thaw |
Pull Request unblocked - code freeze is over.
…comment Signed-off-by: Andrew Leonard <[email protected]>
…comment Signed-off-by: Andrew Leonard <[email protected]>
…comment Signed-off-by: Andrew Leonard <[email protected]>
…comment Signed-off-by: Andrew Leonard <[email protected]>
…comment Signed-off-by: Andrew Leonard <[email protected]>
…comment Signed-off-by: Andrew Leonard <[email protected]>
…comment Signed-off-by: Andrew Leonard <[email protected]>
…comment Signed-off-by: Andrew Leonard <[email protected]>
…comment Signed-off-by: Andrew Leonard <[email protected]>
…comment Signed-off-by: Andrew Leonard <[email protected]>
…comment Signed-off-by: Andrew Leonard <[email protected]>
test |
…comment Signed-off-by: Andrew Leonard <[email protected]>
test |
…comment Signed-off-by: Andrew Leonard <[email protected]>
…comment Signed-off-by: Andrew Leonard <[email protected]>
…comment Signed-off-by: Andrew Leonard <[email protected]>
Code freeze is still incorrectly enabled on "master" branches.
This is because "issue_comment" event has no direct ability for branch filtering, it is a generic event.
To enable issue_comment filtering, we need to get the PR head ref branch, and perform a check
before using code-freeze.yml.