Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added non-breaking db implementation specific settings support to collection definition. #56

Merged
merged 4 commits into from
Aug 8, 2017

Conversation

nanov
Copy link
Contributor

@nanov nanov commented Aug 3, 2017

"repositorySettings" object can now be added to the collection definition containing specific settings per implementation. If the implementation is used those are passed to the repository via extend. How and if those settings are used depends on the viewmodel db implementation.

d.defineCollection({
   name: "col",
   repositorySettings: {
     elasticsearch: {
        // specific elasticsearch settings
     },
     mongodb: {
        // specific mongodb settings
     }
   }
});

@adrai
Copy link
Contributor

adrai commented Aug 7, 2017

Can you remove the package-lock.json ?

@nanov
Copy link
Contributor Author

nanov commented Aug 7, 2017

done :)

@adrai adrai merged commit 9c46787 into thenativeweb:master Aug 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants