elasticsearch6 driver bulkCommit implementation #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrai
reviewed
Apr 11, 2018
lib/databases/elasticsearch6.js
Outdated
| @@ -150,10 +154,14 @@ _.extend(Elasticsearch.prototype, { | |||
| }, | |||
| function(err, res) { | |||
| if (err) { | |||
| return callback(err); | |||
| console.log('---') | |||
There was a problem hiding this comment.
probably not needed, right? ;-)
|
hmm, for some reason mocha hangs after finish, any ideas? |
adrai
reviewed
Apr 11, 2018
lib/databases/elasticsearch6.js
Outdated
| obj = vm.attributes; | ||
| bulkOperation.push( | ||
| { index: { _index: self.indexAndTypeName, _type: self.indexAndTypeName, _id: vm.id, op_type: 'create' } }, | ||
| obj, |
There was a problem hiding this comment.
not really, but there is a trailing comma which is a problem on older node
|
nailed it ;) |
|
nice job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A basic bulkCommit implementation.
Additional things that can be done:
*. By huge amount of updates / vms ( ex: 500+, configurable of course) at once, the bulk operation can be split into smaller ones.
*. Introduction of BulkCommitError which is a container of multiple errors and can be feed it with individual errors for each vm ( will need some a little rework from the other implementations ).