Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose OVERLOAD_VERSION to the whole solution #373

Open
adriengivry opened this issue Feb 15, 2025 · 2 comments
Open

Expose OVERLOAD_VERSION to the whole solution #373

adriengivry opened this issue Feb 15, 2025 · 2 comments
Labels
Feature New feature to the engine Good First Issue An easy issue for new contributors

Comments

@adriengivry
Copy link
Owner

Problem this feature should fix
The new OVERLOAD_VERSION is only visible in the editor

Expected solution
Expose OVERLOAD_VERSION in the main premake5.lua file so it's visible to all the projects.
@adriengivry adriengivry added Feature New feature to the engine Good First Issue An easy issue for new contributors labels Feb 15, 2025
@sameep-git
Copy link
Contributor

Would this just involve moving this line to a higher scope?

Overload/Sources/Overload/OvEditor/premake5.lua

Line 33 in d70a791

defines { "OVERLOAD_VERSION=\"" .. version .. "\"" }

@adriengivry
Copy link
Owner Author

Yep! We would need this in the solution scope, next to the "LUA_SCRIPTING" one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature New feature to the engine Good First Issue An easy issue for new contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adriengivry @sameep-git