Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update-method of Mesh: Add optional points-argument #521

Merged
merged 7 commits into from
Aug 29, 2023
Merged

Conversation

adtzlr
Copy link
Owner

@adtzlr adtzlr commented Aug 29, 2023

and make the cells argument also optional, changes

Mesh.update(cells, cell_type=None)`

to

Mesh.update(points=None, cells=None, cell_type=None)`

closes #522

@adtzlr adtzlr added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 29, 2023
@adtzlr adtzlr self-assigned this Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (754f2cf) 97.93% compared to head (2b79a64) 97.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #521   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files          85       85           
  Lines        4020     4023    +3     
=======================================
+ Hits         3937     3940    +3     
  Misses         83       83           
Files Changed Coverage Δ
src/felupe/mesh/_discrete_geometry.py 100.00% <100.00%> (ø)
src/felupe/region/_boundary.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adtzlr adtzlr merged commit 157903c into main Aug 29, 2023
@adtzlr adtzlr deleted the mesh-update-points branch August 29, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mesh: Option to update all entities (points, cells, cell_type)
1 participant