Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert code to es5 for CRA compat (#30) #31

Merged
merged 1 commit into from
Oct 5, 2017
Merged

convert code to es5 for CRA compat (#30) #31

merged 1 commit into from
Oct 5, 2017

Conversation

aem
Copy link
Owner

@aem aem commented Oct 4, 2017

resolves #30

@jonzlin95

@codecov-io
Copy link

Codecov Report

Merging #31 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   93.91%   93.78%   -0.13%     
==========================================
  Files           4        4              
  Lines         115      177      +62     
  Branches       22       28       +6     
==========================================
+ Hits          108      166      +58     
- Misses          7       11       +4
Impacted Files Coverage Δ
index.js 100% <ø> (ø) ⬆️
src/docsSoap.js 94.26% <0%> (-0.64%) ⬇️
src/constants.js 100% <0%> (ø) ⬆️
src/parseHTML.js 75% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7028911...4f0be07. Read the comment docs.

@aem aem merged commit 545a1d9 into master Oct 5, 2017
@aem aem deleted the es5-ify branch October 5, 2017 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package is ES6 in NPM.
2 participants