-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API] not using core/v1 pod spec #132
Comments
Initially, the spec was inspired by the Victoriametrics operator and highly changed by the maintainers team. Our type gives us the ability to disable the propagation of some fields. Also, we can make sure that podSpec will work correctly in all K8s versions that the operator should support. If you need some fields that are now not presented in our podSpec, please rise an issue and we will add it. Also all contributions are always welcome! |
I figured out a background, thank you. The cluster controller create or update etcd pods from above PodSpec, so it should replace spec type to k8s core v1. |
Thanks for your suggestion. The maintainers are divided in opinions on this matter. I would encourage you to offer your viewpoint under #172. |
This is completed by #175. Let us know what you think and feel free to comment or open a new issue if you feel that there's more work to be done in this direction. |
https://github.com/aenix-io/etcd-operator/blob/main/api/v1alpha1/etcdcluster_types.go#L140
etcd cluster pod template has a member: "PodSpec".
I seems like this field has same values as https://pkg.go.dev/k8s.io/[email protected]/core/v1#PodSpec
Why doesn't use official package's struct, you defined by original?
If there is no specific reason, I think should import and use official package's struct
The text was updated successfully, but these errors were encountered: