Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] wrap/implement Global Alignment DTW #444

Open
TonyBagnall opened this issue May 18, 2023 · 4 comments
Open

[ENH] wrap/implement Global Alignment DTW #444

TonyBagnall opened this issue May 18, 2023 · 4 comments
Assignees
Labels
distances Distances package enhancement New feature, improvement request or other non-bug code enhancement implementing algorithms Implementing new algorithms/estimators

Comments

@TonyBagnall
Copy link
Contributor

Describe the feature or idea you want to propose

there is an interesting paper here, that describes an extension of DTW
https://arxiv.org/pdf/2002.03848.pdf
described here
https://rtavenar.github.io/hdr/parts/01/dtw/dtw_gi.html

Describe your proposed solution

It might already be in tslearn, in which case we can maybe wrap it, although might be better to port it in for numba reasons?

Describe alternatives you've considered, if relevant

No response

Additional context

No response

@TonyBagnall TonyBagnall added enhancement New feature, improvement request or other non-bug code enhancement good first issue Good for newcomers implementing algorithms Implementing new algorithms/estimators distances Distances package labels May 18, 2023
@SalmanDeveloperz
Copy link

Hi Maintainers,

I am interested in contributing to this issue. I wanted to confirm if the Global Alignment DTW feature is already implemented in tslearn. If not, would you prefer it to be wrapped from an existing implementation or ported directly for performance optimization using numba?

I am happy to start working on this and would appreciate any guidance or additional context.
Thanks

@baraline
Copy link
Member

Hi @SalmanDeveloperz,

By philosophy, we prefer to have our own implementation instead of warper when it's possible/reasonable. I think @chrisholder would be best suited to guide you on the details this issue and the state of the distance module.

Meanwhile, I'm sure you can start with some the implemented dtw inside the distance module and try to make the modification pour global alignment in a copy of it. That should get you started !

@tanishy7777
Copy link

By philosophy, we prefer to have our own implementation instead of warper when it's possible/reasonable. I think @chrisholder would be best suited to guide you on the details this issue and the state of the distance module.

Hi, Can I work on this? It seems like no one is working on it?

@tanishy7777
Copy link

@aeon-actions-bot assign @tanishy7777

@aeon-actions-bot aeon-actions-bot bot removed the good first issue Good for newcomers label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distances Distances package enhancement New feature, improvement request or other non-bug code enhancement implementing algorithms Implementing new algorithms/estimators
Projects
None yet
Development

No branches or pull requests

4 participants