Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IR encoding omits deprecated #1050

Open
klittlepage opened this issue Feb 3, 2025 · 0 comments · May be fixed by #1049
Open

IR encoding omits deprecated #1050

klittlepage opened this issue Feb 3, 2025 · 0 comments · May be fixed by #1049

Comments

@klittlepage
Copy link

The SBE IR schema sbe-ir.xml defines a field deprecated

simple-binary-encoding/sbe-tool/src/main/resources/sbe-ir.xml

Line 87 in 0da03ae

<field name="deprecated" id="10" type="deprecatedVersionType"/>

Currently, the Encoding and IrEncoder classes don't correctly handle this field, resulting in uninitialized/invalid values in the serialized IR. This patch sets deprecated and produces serialized IR with deprecated set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: include field 'deprecated' in ir encoding and decoding klittlepage/simple-binary-encoding
1 participant
@klittlepage