Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support com.aerospike:aerospike-client-jdk21 (for using virtual threads) #807

Open
KimSoungRyoul opened this issue Dec 17, 2024 · 2 comments

Comments

@KimSoungRyoul
Copy link

KimSoungRyoul commented Dec 17, 2024

support com.aerospike:aerospike-client-jdk21

https://github.com/aerospike/spring-data-aerospike/blob/main/pom.xml#L33

<!-- https://github.com/aerospike/spring-data-aerospike/blob/main/pom.xml#L33  -->
   <properties>
        <java.version>21</java.version>
        <!--<java.version>17</java.version> -->
        <maven.compiler.source>${java.version}</maven.compiler.source>
        <maven.compiler.target>${java.version}</maven.compiler.target>
        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
        <springdata.commons>3.4.0</springdata.commons>
        <spring-boot-starter-test>3.3.0</spring-boot-starter-test>
        <spring-cloud-starter-bootstrap>4.1.5</spring-cloud-starter-bootstrap>
        <spring-tx>6.2.0</spring-tx>
        <maven.javadoc.plugin>3.3.0</maven.javadoc.plugin>
        <maven.gpg.plugin>1.6</maven.gpg.plugin>
       <!--<aerospike-client-jdk8>9.0.2</aerospike-client-jdk8> -->
        <aerospike-client-jdk21>9.0.2</aerospike-client-jdk21>
   </properties>
@KimSoungRyoul KimSoungRyoul changed the title support for com.aerospike:aerospike-client-jdk21 (for using virtual threads) support com.aerospike:aerospike-client-jdk21 (for using virtual threads) Dec 17, 2024
@reugn
Copy link
Member

reugn commented Jan 19, 2025

Spring Boot currently requires Java 17 as a minimum. Upgrading the Aerospike Java client to a jdk21 version would break this compatibility. We plan to adopt the jdk21 client once Spring Boot no longer supports Java 17. Did your performance tests indicate a significant improvement between the jdk8 and jdk21 Aerospike clients?

@KimSoungRyoul
Copy link
Author

KimSoungRyoul commented Jan 24, 2025

Did your performance tests indicate a significant improvement between the jdk8 and jdk21 Aerospike clients?

yes, this test was performed local(macOS m1) so it may not be accurate, but performance of aerospike-client-jdk8 vs. aerospike-client-jdk21 is more than double different across all metrics

aerospike-client-jdk8 performance

Image
Image

aerospike-client-jdk21 performance

Image
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants