-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docker): fix Dockerfile #17
Conversation
.github/workflows/docker.yml
Outdated
|
||
- name: Log in to Docker Hub | ||
if: github.event_name != 'pull_request' | ||
uses: docker/login-action@f054a8b539a109f9f41c372932f1ae047eff08c9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
too specific version, I don't think so there is a reason for that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
v* tags and master, does it also push a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
posted couple of comments
also using asdf
(this tool name looks like typo 🤣 ) seems like a overkill, but whatever
No other way to install these old versions of erlang and elixir , if you suggest one , will be happy to replace asdf. |
Actually , from my understanding it add latest tag on every push in master. |
PTAL and let me know ,if I can merge already. |
I don't think that's a good strategy as the |
The pipelines are updated , please check them and let me know , if you think something need to be changed . |
Merged in the Dockerfile |
Summary:
|
It was really hard to build it , please take a look and if you have suggestions to improve , let me know in the comments.
We have to choose on what events , branches ,etc to run the build and push.