Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): fix Dockerfile #17

Merged
merged 17 commits into from
Aug 31, 2022
Merged

fix(docker): fix Dockerfile #17

merged 17 commits into from
Aug 31, 2022

Conversation

mmpetarpeshev
Copy link
Contributor

@mmpetarpeshev mmpetarpeshev commented Oct 6, 2021

It was really hard to build it , please take a look and if you have suggestions to improve , let me know in the comments.
We have to choose on what events , branches ,etc to run the build and push.

@mmpetarpeshev mmpetarpeshev changed the title fix(docker): Fix Dockerfile fix(docker): fix Dockerfile Oct 7, 2021

- name: Log in to Docker Hub
if: github.event_name != 'pull_request'
uses: docker/login-action@f054a8b539a109f9f41c372932f1ae047eff08c9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too specific version, I don't think so there is a reason for that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@dincho
Copy link
Member

dincho commented Oct 8, 2021

We have to choose on what events , branches ,etc to run the build and push.

v* tags and master, does it also push a latest docker tags on every v* tag build ?

Copy link
Member

@dincho dincho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

posted couple of comments

also using asdf (this tool name looks like typo 🤣 ) seems like a overkill, but whatever

@mmpetarpeshev
Copy link
Contributor Author

mmpetarpeshev commented Oct 8, 2021

posted couple of comments

also using asdf (this tool name looks like typo 🤣 ) seems like a overkill, but whatever

No other way to install these old versions of erlang and elixir , if you suggest one , will be happy to replace asdf.
The old installation method in the Dockerfile doesn't work for erlang 21.

@mmpetarpeshev
Copy link
Contributor Author

mmpetarpeshev commented Oct 8, 2021

We have to choose on what events , branches ,etc to run the build and push.

v* tags and master, does it also push a latest docker tags on every v* tag build ?

Actually , from my understanding it add latest tag on every push in master.

@mmpetarpeshev
Copy link
Contributor Author

mmpetarpeshev commented Oct 19, 2021

PTAL and let me know ,if I can merge already.

@dincho
Copy link
Member

dincho commented Nov 2, 2021

Actually , from my understanding it add latest tag on every push in master.

I don't think that's a good strategy as the latest in docker is the default, which should be a stable version IMO (i.e. latest tag)

@mmpetarpeshev
Copy link
Contributor Author

The pipelines are updated , please check them and let me know , if you think something need to be changed .

@radrow
Copy link
Member

radrow commented Aug 31, 2022

Merged in the Dockerfile

@radrow
Copy link
Member

radrow commented Aug 31, 2022

Summary:

  • We use google release please , on release with it , it will deploy to prod.
  • On push in master , it will deploy to prod with another url (this one should be added in the gitops repo)
  • On open PR will deploy to stg and the url will printed in the PR comments.
  • If there is an issue with the build or something else on the initial PR open , it should be closed and open again , not reopen, because the gh events are important.
  • On PR sync with will sync and the deploy

@radrow radrow merged commit 33b9cff into master Aug 31, 2022
@radrow radrow deleted the fix/fix-dockerfile branch August 31, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants