Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check Experiment, Screen and EyeTracker for equality #919

Open
3 tasks
dkrako opened this issue Jan 8, 2025 · 0 comments
Open
3 tasks

check Experiment, Screen and EyeTracker for equality #919

dkrako opened this issue Jan 8, 2025 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers nonessential nice to have

Comments

@dkrako
Copy link
Contributor

dkrako commented Jan 8, 2025

Description of the problem

There are a lot of places in our source and test code that manually checks for equality of Experiment, Screen or EyeTracker objects.

Description of a solution

Create a method like Experiment.__eq__(Experiment: other) -> bool with corresponding methods for the Screen and EyeTracker classes.

Minimum acceptance criteria

  • Experiment.__eq__(Experiment: other) -> bool
  • Screen.__eq__(Screen: other)
  • EyeTracker.__eq__(EyeTracker: other)

Context

Here's some further information for reference: https://stackoverflow.com/questions/390250/elegant-ways-to-support-equivalence-equality-in-python-classes

@dkrako dkrako added enhancement New feature or request good first issue Good for newcomers essential important labels Jan 8, 2025
@dkrako dkrako changed the title create method to check Experiment, Screen and EyeTracker for equality check Experiment, Screen and EyeTracker for equality Jan 8, 2025
@dkrako dkrako added nonessential nice to have and removed essential important labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers nonessential nice to have
Projects
None yet
Development

No branches or pull requests

1 participant