Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib-2.0-rc1: inconsistency of Nat..*-cancelˡ-≡ with AlmostLeftCancellative #2179

Closed
mechvel opened this issue Oct 22, 2023 · 1 comment
Closed
Labels
status: duplicate The main contents of the issue or PR already exists in another issue or PR.

Comments

@mechvel
Copy link
Contributor

mechvel commented Oct 22, 2023

In Algebra.Definitions.AlmostLeftCancellative the order of the arguments x, y, z differs from such order in
Nat.Properties.*-cancelˡ-≡.
I suggest to change respectively this order in Nat.Properties.*-cancelˡ-≡.
Probably the same needs to be done to *-cancelʳ-≡.

It would be nice to set *-cancelˡ-≡ : AlmostLeftCancellative 0 _*_.
But unfortunately, the definition of "nonzero" for ℕ is not a special case of ≉ 0# in Semiring.

@jamesmckinna
Copy link
Contributor

This is a duplicate of your still-open issue #1562 for which the core maintenance team reluctantly decided there was insufficient resource to fix for v2.0; our decision was that it be pushed to v3.0, the intended next label:breaking release of the library. Suggest your continue to comment, if necessary, on #1562 . Closing this one in the meantime.

@jamesmckinna jamesmckinna added the status: duplicate The main contents of the issue or PR already exists in another issue or PR. label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate The main contents of the issue or PR already exists in another issue or PR.
Projects
None yet
Development

No branches or pull requests

2 participants