From 3f4f214c0b55d1806db7f77f8b83e10443419ede Mon Sep 17 00:00:00 2001 From: James Sidhu Date: Wed, 16 Jan 2019 02:43:40 +0000 Subject: [PATCH] [stable/verdaccio] add optional fixed nodePort to service when NodePort service type used (#10662) Signed-off-by: James Sidhu --- stable/verdaccio/Chart.yaml | 2 +- stable/verdaccio/README.md | 3 ++- stable/verdaccio/templates/service.yaml | 5 +++++ stable/verdaccio/values.yaml | 1 + 4 files changed, 9 insertions(+), 2 deletions(-) diff --git a/stable/verdaccio/Chart.yaml b/stable/verdaccio/Chart.yaml index 48e619cb0a0a..3088fd8f0e27 100644 --- a/stable/verdaccio/Chart.yaml +++ b/stable/verdaccio/Chart.yaml @@ -1,7 +1,7 @@ apiVersion: v1 description: A lightweight private npm proxy registry (sinopia fork) name: verdaccio -version: 0.6.0 +version: 0.6.1 appVersion: 3.10.0 home: http://www.verdaccio.org icon: https://raw.githubusercontent.com/verdaccio/verdaccio/master/assets/bitmap/logo/logo-twitter.png diff --git a/stable/verdaccio/README.md b/stable/verdaccio/README.md index 08a9f5d9f945..06cafb2b55f3 100644 --- a/stable/verdaccio/README.md +++ b/stable/verdaccio/README.md @@ -55,7 +55,7 @@ and their default values. | `customConfigMap` | Use a custom ConfigMap | `false` | | `image.pullPolicy` | Image pull policy | `IfNotPresent` | | `image.repository` | Verdaccio container image repository | `verdaccio/verdaccio` | -| `image.tag` | Verdaccio container image tag | `3.10.0` | +| `image.tag` | Verdaccio container image tag | `3.10.0` | | `nodeSelector` | Node labels for pod assignment | `{}` | | `persistence.accessMode` | PVC Access Mode for Verdaccio volume | `ReadWriteOnce` | | `persistence.enabled` | Enable persistence using PVC | `true` | @@ -73,6 +73,7 @@ and their default values. | `service.loadBalancerIP` | IP address to assign to load balancer (if supported) | `""` | | `service.loadBalancerSourceRanges` | List of IP CIDRs allowed access to load balancer (if supported) | `[]` | | `service.port` | Service port to expose | `4873` | +| `service.nodePort` | Service port to expose | none | | `service.type` | Type of service to create | `ClusterIP` | Specify each parameter using the `--set key=value[,key=value]` argument to `helm install`. For example, diff --git a/stable/verdaccio/templates/service.yaml b/stable/verdaccio/templates/service.yaml index 50ee8ddf1fd4..1ef1d261a555 100644 --- a/stable/verdaccio/templates/service.yaml +++ b/stable/verdaccio/templates/service.yaml @@ -29,6 +29,11 @@ spec: targetPort: http protocol: TCP name: {{ .Values.service.name }} + {{- if contains "NodePort" .Values.service.type }} + {{- if .Values.service.nodePort }} + nodePort: {{ .Values.service.nodePort }} + {{- end }} + {{- end }} selector: app: {{ template "verdaccio.name" . }} release: {{ .Release.Name }} diff --git a/stable/verdaccio/values.yaml b/stable/verdaccio/values.yaml index 91c460b1e61d..de03342a8b43 100644 --- a/stable/verdaccio/values.yaml +++ b/stable/verdaccio/values.yaml @@ -16,6 +16,7 @@ service: loadBalancerSourceRanges: [] port: 4873 type: ClusterIP + # nodePort: 31873 ## Node labels for pod assignment ## Ref: https://kubernetes.io/docs/user-guide/node-selection/