Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on variable values, not only presense #11

Open
bobrik opened this issue Jul 30, 2015 · 0 comments
Open

Rely on variable values, not only presense #11

bobrik opened this issue Jul 30, 2015 · 0 comments

Comments

@bobrik
Copy link

bobrik commented Jul 30, 2015

It it quite convenient to use map in nginx configuration. You can map tokens and secrets to hosts, but you cannot do the same with whitelists and boolean-ish variables. Current code only check for variable presence, you cannot explicitly disable things.

I suggest to add an extra check for currently problematic variables. Instead of

if whitelist then
 -- stuff
end

let's do

if whitelist and whitelist:len() > 0 then
  -- stuff
end

Setting ngo_secure_cookies to false should also work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant