-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flip route change #3
Comments
I can see that you use react-router's react-flip-toolkit-router-example/src/IconSetPage/index.js Lines 99 to 104 in 5522d1b
What is the purpose? Was it used to delay the unmount of the route? This does not work for me, i just get an alert window with "350" in it. Why not to use something like react-transition-group here?
|
Hi, sorry for the delay in reply. You're right that I was using a somewhat hacky method to keep the route component in the dom, I think I should have used the children func instead. I will look into it more tonight and get back to you. |
The main difference (which causes my problem) with your example is that you render the If I understand correctly, |
I think playing with the flipId is not a workaround but rather the suggested way to handle this -- maybe just stop rendering it for the elements on the exiting page? |
Actually, I found that I can use |
Hi, thanks for an awesome lib! I was trying to make a page transition effect with the following structure
Basically, I have two pages, one page with 6 cards, another is just a page with all the info about a selected card. When I click the card it should expand to a full page. Everything is fine with
page -> card
transition, butcard -> page
looks bad. When I click the card the whole page disappears instantly and I see the animation of expanding page on a white screen. Looks like it is removed from DOM too early. What am I missing?The text was updated successfully, but these errors were encountered: