Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set_substitution crashes every time #142

Closed
snoopyjc opened this issue Mar 25, 2020 · 2 comments
Closed

set_substitution crashes every time #142

snoopyjc opened this issue Mar 25, 2020 · 2 comments

Comments

@snoopyjc
Copy link
Contributor

set_substitution crashes because self._subs does not exist.

The variable is called self._sub.

Also, the regex needs to be precompiled here, and if None is passed, the variable should not be set after you delete it.
@snoopyjc
Copy link
Contributor Author

I'm fixing this.

@snoopyjc snoopyjc mentioned this issue Mar 29, 2020
Merged
@kirsle
Copy link
Member

kirsle commented Apr 10, 2020

Fixed in #144.

@kirsle kirsle closed this as completed Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kirsle @snoopyjc