PaperTrail is enabled by default for a controller even if it's disabled in general

[maxcosworth]

By default, the method paper_trail_enabled_for_controller always returns true, even if you have previously set PaperTrail.enabled = false.

That was making some of my controller specs to fail because PaperTrail was trying to call the user_for_paper_trail method, because paper_trail_enabled_for_controller is always true. And those controllers don't handle authentication.

I've a fix but I'd need to write some tests for it. Ok to ask for a pull-request?

[batter]

Sounds good to me. Even better if you can write tests for it 👍

[batter]

@maxcosworth - Any news on this? I just took a crack at an implementation but I'm not sure it covers everything. After reviewing this a little more closely I'm thinking that perhaps that the enabled_for_controller method is returning properly, but that the set_paper_trail_whodunnit method (this line) should be changed to this:

def set_paper_trail_whodunnit
  ::PaperTrail.whodunnit = user_for_paper_trail if paper_trail_enabled_for_controller && ::PaperTrail.enabled?
end

I think this makes more sense than trying to change the paper_trail_enabled_for_controller method since it is intended to be overwritten if desired. Also, I would think that in a case like yours, you might just overwrite the user_for_paper_trail method to return nil on that Controller?

[batter]

@maxcosworth - I'm trying to get a move on releasing 3.0.0, so I went ahead and implemented what I thought was the proper solution for this. Please take a look at 9dd154a, I think it should address the issue you were having.

[maxcosworth]

Yep, it's ok, thanks. Sorry, I couldn't find time to submit the PR at the end.

[petervandenabeele]

I have the impression this commit triggered #293