You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When we create a new brush rect, we can move the mouse outside the brush area while dragging. If we don't trigger mouseup we can move the mouse back in to the brush area to continue dragging. But when we trigger a drag from BrushHandle and move mouse outside the brush area it immediately triggers dragEnd which prevents us to continue brushing by moving mouse inside the brush area.
Drag the brush from left or right handle and move mouse outside the brush area.
Move back mouse inside the brush area while holding left mouse button.
See that brush no longer moves.
I think we should be able to move brush even if the mouse leaves the brush area or handle.
Correct behavior in BaseBrush
The problem with BrushHandle
This is a minor issue with the user experience of Brush component. But there seems to be a bigger problem. Currently, the component cannot catch up with fast mouse move events, if you move mouse outside the brush area too fast, it will leave the brush a bit far from the edge of the brush area. If you check this d3 demo you can see that no matter how fast you move mouse outside, it stops on the edge of the brush area. This greatly improves the user experience with the component. Here's the fast drag issue;
Thank you for this great library. It makes it a lot easier to create complex charts in React. Hoping to see more.
The text was updated successfully, but these errors were encountered:
When we create a new brush
rect
, we can move the mouse outside the brush area while dragging. If we don't triggermouseup
we can move the mouse back in to the brush area to continue dragging. But when we trigger a drag fromBrushHandle
and move mouse outside the brush area it immediately triggersdragEnd
which prevents us to continue brushing by moving mouse inside the brush area.Steps to reproduce the behavior:
I think we should be able to move brush even if the mouse leaves the brush area or handle.
Correct behavior in
BaseBrush
The problem with
BrushHandle
This is a minor issue with the user experience of
Brush
component. But there seems to be a bigger problem. Currently, the component cannot catch up with fast mouse move events, if you move mouse outside the brush area too fast, it will leave the brush a bit far from the edge of the brush area. If you check this d3 demo you can see that no matter how fast you move mouse outside, it stops on the edge of the brush area. This greatly improves the user experience with the component. Here's the fast drag issue;Thank you for this great library. It makes it a lot easier to create complex charts in React. Hoping to see more.
The text was updated successfully, but these errors were encountered: