Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor client certificate code on source-mysql and source-postgres #15529

Closed
rodireich opened this issue Aug 10, 2022 · 1 comment · Fixed by #15993
Closed

Refactor client certificate code on source-mysql and source-postgres #15529

rodireich opened this issue Aug 10, 2022 · 1 comment · Fixed by #15993
Assignees
@rodireich
Labels
area/connectors Connector related issues autoteam connectors/source/mysql connectors/source/postgres needs-triage type/enhancement New feature or request

Comments

@rodireich
Copy link
Contributor

connectors that need to support client certificate authentication would share a large part of their source.
In addition the nature of dealing with private key information (password) makes it essential to minimize duplication and use a single and optimized implementation for certificate handling.

The goals of refactoring are:

  1. Unify as much as we can the code used for support of client certificate authentication.
  2. Tighten current implementation: keep as much of the flow as we can to JVM by not using system calls or saving files to filesystem.
  3. Create a single approach that will be used on future connectors support. Allow flexibility for specific requirements of different connectors.
@rodireich rodireich added type/enhancement New feature or request needs-triage labels Aug 10, 2022
@rodireich rodireich self-assigned this Aug 10, 2022
@rodireich rodireich mentioned this issue Aug 10, 2022
Merged
37 tasks
@rodireich
Copy link
Contributor Author

Add also the missing support for ssl in source-postgres CDC
#15167

@grishick grishick mentioned this issue Aug 24, 2022
Merged
37 tasks
@rodireich rodireich linked a pull request Aug 25, 2022 that will close this issue
New ssl flow for connectors #15993
Merged
37 tasks
@rodireich rodireich mentioned this issue Aug 26, 2022
Merged
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rodireich rodireich

Labels
area/connectors Connector related issues autoteam connectors/source/mysql connectors/source/postgres needs-triage type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New ssl flow for connectors airbytehq/airbyte
2 participants
@rodireich @octavia-squidington-iii