Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor useFreeConnectorProgram() so it does not fire in OSS #21872

Closed
josephkmh opened this issue Jan 25, 2023 · 0 comments · Fixed by #21892
Closed

Refactor useFreeConnectorProgram() so it does not fire in OSS #21872

josephkmh opened this issue Jan 25, 2023 · 0 comments · Fixed by #21892
Labels
area/frontend Related to the Airbyte webapp team/compose

Comments

@josephkmh
Copy link
Contributor

Right now useFreeConnectorProgram() is called in several places in OSS which results in a useQuery() that ultimately fails. Due to the implementation, this failed query produces the desired effect (FCP UI is not rendered in OSS). But ideally we should not be calling this query at all in unsupported environments.

Instead, we should create a new FeatureItem that represents the FCP. This feature is permanently disabled in OSS, so it's a better fit for the FeatureService than the ExperimentService anyway.

In addition, this will avoid conflicts with the ongoing config provider refactor: #21456

cc @ambirdsall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp team/compose
Projects
None yet
1 participant