Google Ads Connector says it supports multiple customer ids but only accepts one.

[cgardens]

Expected Behavior

• Google Ads allows taking in multiple customer ids at once.
• Google Ads connector allows taking multiple customer ids at once

Current Behavior

• Google Ads connector says it allows multiple customer ids at once
• Google Ads connector does not allow taking multiple customer ids at once

Steps to Reproduce

Airbyte Version

0.19.0-alpha

Connector Version (if applicable)

Adwords: 0.2.1

[cgardens]

@sherifnada fyi

[jamakase]

Isn't it better to handle such case as array of strings as we already have component for this?

[cgardens]

yes. i agree artem. that sounds like the better approach.

[sherifnada]

agreed that this should be a string list. I'm not sure there is a way of changing this type without breaking backwards compatibility.

should be a simple fix to change the spec pattern from ^[0-9]{10}$ to ^[0-9]{10}(,[0-9]{10})*$

[michel-tricot]

I think we should break backward compatibility here. We will need a strategy to handle that in the future.

[keu]

@sherifnada so what will be the fix? are we going for a list or string?

[po3na4skld]

@sherifnada so what will be the fix? are we going for a list or string?

As I understood, UI supports list so we will use it and not a string

[po3na4skld]

During integration testing I got one test failed. Test is failing due to the fact that the stream is actually empty when trying to do testIncrementalSyncWithState. The name of the stream: KEYWORDS_PERFORMANCE_REPORT

The problem is also described in this issue: #2929