Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDK: Override time.sleep to make it no-op #6217

Closed
htrueman opened this issue Sep 17, 2021 · 0 comments
Closed

CDK: Override time.sleep to make it no-op #6217

htrueman opened this issue Sep 17, 2021 · 0 comments
Labels
area/connectors Connector related issues autoteam team/extensibility type/enhancement New feature or request

Comments

@htrueman
Copy link
Contributor

Tell us about the problem you're trying to solve

Override time.sleep in CDK tests to don't wait sleep time during tests run.

Describe the solution you’d like

We may just mock time.sleep in the tests core to be applicable to all of the CDK tests.

Describe the alternative you’ve considered or used

Make time.sleep configurable. This solutions requires a refactoring of the existing code. No really usable for the further development.

Additional context

The issue appeared in #5248 (comment)

Are you willing to submit a PR?

This issue does not require any additional knowledge so far, so may be taken by anyone from the team
@htrueman htrueman added the type/enhancement New feature or request label Sep 17, 2021
@htrueman htrueman mentioned this issue Sep 17, 2021
Merged
36 tasks
@sherifnada sherifnada added the area/connectors Connector related issues label Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/connectors Connector related issues autoteam team/extensibility type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bleonard @sherifnada @htrueman