Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use typed timestamps in AirbyteProtocol #979

Closed
sherifnada opened this issue Nov 15, 2020 · 1 comment
Closed

Use typed timestamps in AirbyteProtocol #979

sherifnada opened this issue Nov 15, 2020 · 1 comment
Labels
type/enhancement New feature or request

Comments

@sherifnada
Copy link
Contributor

Tell us about the problem you're trying to solve

the emitted_at column in AirbyteRecordMessage is a number, but does not have any type information in its JSON schema definition about the unit of this number. This can cause confusion when consuming this timetsamp field (e.g: should it be interpreted as millis or seconds?). JsonSchema provides typed formats for expressing dates -- it would be better to use one of them instead.
@sherifnada sherifnada added the type/enhancement New feature or request label Nov 15, 2020
@sherifnada sherifnada mentioned this issue Nov 15, 2020
Merged
@michel-tricot michel-tricot mentioned this issue Nov 26, 2020
Closed
@sherifnada
Copy link
Contributor Author

Airbyte now supports this, it's destination/source specfic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sherifnada