Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source-defined comparable #989

Closed
cgardens opened this issue Nov 16, 2020 · 1 comment
Closed

Source-defined comparable #989

cgardens opened this issue Nov 16, 2020 · 1 comment
Assignees
Labels
type/enhancement New feature or request
Milestone

Comments

@cgardens
Copy link
Contributor

cgardens commented Nov 16, 2020

Child of #987

Tell us about the problem you're trying to solve

Likely worth just trying to migrate a source that should define its own comparable (e.g. exchange rates api) to use incremental and then see if there's anything that needs to be done to make it easier to support it. There may be some helpers that are worth writing. Then again there may be nothing extra that need to be done at all.

@cgardens cgardens added the type/enhancement New feature or request label Nov 16, 2020
@cgardens cgardens added this to the v0.6.0 milestone Nov 16, 2020
@cgardens cgardens modified the milestones: v0.6.0, v0.7.0 Nov 23, 2020
@sherifnada
Copy link
Contributor

For non-singer integrations, this should just be an implementation rather than an iface change. Example is #1080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants