Point clouds #100
Merged
Point clouds #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Victorlouisdg, I'm afraid my refactor of #105 has caused some merge conflicts |
|
Should be easy to fix, I'll have a look next Monday. |
tlpss
reviewed
Jan 17, 2024
| from airo_typing import PointCloud | ||
|
|
||
|
|
||
| def point_cloud_to_open3d(point_cloud: PointCloud) -> Any: # TODO: change Any back to o3d.t.geometry.PointCloud |
There was a problem hiding this comment.
why is the o3d type not used here?
There was a problem hiding this comment.
I don't remember the exact reason, but I guess mypy didn't like it.
tlpss
reviewed
Jan 17, 2024
airo-camera-toolkit/airo_camera_toolkit/point_clouds/operations.py
Outdated
Show resolved
Hide resolved
tlpss
approved these changes
Jan 17, 2024
tlpss
reviewed
Jan 17, 2024
| """ a dictionary of numpy arrays that represent additional attributes of a point cloud, e.g. normals, confidence, etc. """ | ||
|
|
||
|
|
||
| @dataclass |
There was a problem hiding this comment.
makes me wonder if we should rename this package to airo-core to facilitate putting both types, interfaces and some data containers here. This would be quite the breaking change though
There was a problem hiding this comment.
I see your point, but moving e.g. the Camera interfaces or SE3Container here feels a bit weird.
tlpss
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ColoredPointCloudTypereplaced byPointClouddataclass