Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock NumPy to versions below 2.0 #155

Merged
merged 4 commits into from
Feb 6, 2025
Merged

Lock NumPy to versions below 2.0 #155

merged 4 commits into from
Feb 6, 2025

Conversation

m-decoster
Copy link
Contributor

Describe your changes

Locks numpy < 2.0 for all packages, because our OpenCV version was incompatible with newer NumPy versions.

See, e.g., this workflow run: https://github.com/airo-ugent/airo-mono/actions/runs/13111963494/job/36577677885

Checklist

  • Have you modified the changelog?

The locked OpenCV version we are using does not work with Numpy>=2.0
@m-decoster m-decoster changed the title Numpy version1 Lock NumPy to versions below 2.0 Feb 4, 2025
@tlpss
Copy link
Contributor

tlpss commented Feb 4, 2025

@m-decoster, do we want to lock on np < 2? or should we test with a newer version of opencv?

Afaik the reason to lock opencv was bc the API tends to change, but not because of specific issues we had with newer versions. @Victorlouisdg (sorry 😛) do you remember any specific issues?

@m-decoster
Copy link
Contributor Author

m-decoster commented Feb 5, 2025

@m-decoster, do we want to lock on np < 2? or should we test with a newer version of opencv?

OpenCV version 4.10.0.84 works with numpy>=2, but I haven't tested other libraries yet (and also need to test if all existing code still works)

@Victorlouisdg
Copy link
Contributor

@tlpss I also believe locking OpenCV was a precautionary measure. I also vaguely recall that the ArUco detection API underwent a breaking change once.

@m-decoster
Copy link
Contributor Author

After a short discussion with @tlpss, I suggest:

  • Locking to numpy < 2 for now
  • Create a tracking issue to upgrade to numpy >= 2 when we have time to do extensive testing

@tlpss tlpss merged commit 3c3f55f into main Feb 6, 2025
25 checks passed
@tlpss tlpss deleted the numpy_version1 branch February 6, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants