diff --git a/.github/workflows/python-package.yml b/.github/workflows/python-package.yml index d13e04f..ac50a53 100644 --- a/.github/workflows/python-package.yml +++ b/.github/workflows/python-package.yml @@ -16,7 +16,7 @@ jobs: strategy: fail-fast: false matrix: - python-version: ["3.9", "3.10", "3.11"] + python-version: ["3.8", "3.9", "3.10", "3.11"] steps: - uses: actions/checkout@v4 @@ -38,6 +38,9 @@ jobs: flake8 tests --count --select=E9,F63,F7 --show-source --statistics # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide flake8 tests --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics + - name: Install package + run: | + python -m pip install . - name: Test with pytest run: | pytest diff --git a/src/dllist.c b/src/dllist.c index 9441634..5ae7339 100644 --- a/src/dllist.c +++ b/src/dllist.c @@ -1796,7 +1796,6 @@ static PyObject* dllistiterator_new(PyTypeObject* type, static DLListNodeObject* dllistiterator_advance(PyObject* self) { DLListIteratorObject* iter_self = (DLListIteratorObject*)self; - PyObject* value; if (iter_self->current_node == NULL) { diff --git a/src/sllist.c b/src/sllist.c index 8c883da..2b7806d 100644 --- a/src/sllist.c +++ b/src/sllist.c @@ -1761,7 +1761,6 @@ static PyObject* sllistiterator_new(PyTypeObject* type, static SLListNodeObject* sllistiterator_advance(PyObject* self) { SLListIteratorObject* iter_self = (SLListIteratorObject*)self; - PyObject* value; if (iter_self->current_node == NULL) { diff --git a/tests/speed_test.py b/tests/speed_test.py index 479e5ff..54c9056 100644 --- a/tests/speed_test.py +++ b/tests/speed_test.py @@ -19,7 +19,7 @@ def __enter__(self): def __exit__(self, *exc_details): stop_time = time.time() - assert(self._start_time is not None) + assert self._start_time is not None self.elapsed += stop_time - self._start_time