Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is ncontracts = 867164? #1

Open
jpsgamboa opened this issue May 10, 2018 · 1 comment
Open

Why is ncontracts = 867164? #1

jpsgamboa opened this issue May 10, 2018 · 1 comment

Comments

@jpsgamboa
Copy link

Hi.

Where did you get ncontracts from?

Wont this be outdated now?
@ajcerejeira
Copy link
Owner

Hello, sorry for the very delayed response, I didn't see this issue :-/ .

You are right, it shouldn't be an hardcoded number (it is a bad practice).
At the time I wrote this code I needed the data asap, so I just fetched that number from base.gov.pt.
When I find some spare time I will fix it.

Thanks, for the feedback

@ajcerejeira ajcerejeira reopened this Nov 10, 2018
@ABCurado ABCurado mentioned this issue Dec 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dynamically extract number of contracts ABCurado/base.gov.pt
2 participants
@jpsgamboa @ajcerejeira