Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dandere2xPR v0.0.6 Feedback #18

Open
DCGYT opened this issue Jan 7, 2023 · 8 comments
Open

Dandere2xPR v0.0.6 Feedback #18

DCGYT opened this issue Jan 7, 2023 · 8 comments

Comments

@DCGYT
Copy link

DCGYT commented Jan 7, 2023

Hello again, there has been a breakthrough in the interface.

Regarding the bugs issue, they are still the same. Having to use "Quality Coefficent" at maximum to avoid white dots, "Block Size" high and "Tile Size" at minimum to avoid lines.

Since version 0.0.4.0 I had noticed that the appearance of the videos had changed, now they were more grainy and not as smooth as previous versions. I did not know what to think about it, I thought that maybe it was a bug, but it remains in version 0.0.6. Unless it's a setting to change the quality that I haven't seen.

I don't really understand what "Model" does, I have compared the 3 models above in DaVinci Resolve (re-encoded x264 with avidemux) with a difference filter and they are all exactly the same, should they change something?

If the graininess issue is going to stay in future versions, I would like there to be an option to make it smooth like it was until version 0.0.3.0.

3.7.2 Legacy [vulkan][s2][n3][b60][q100]
image
0.0.3.0 [q100*][b60][d3][cunet][t050][w2]
image
0.0.6 [q10][b60][s2][p1][d3][cunet][t050][w2]
image

https://drive.google.com/drive/folders/1ZxyjDErgJGih6EyGzMY_QBjTN2gwtMLV?usp=share_link

@akai-katto
Copy link
Owner

Thanks for pointing out the graininess issue, I know where it probably came from. I'll work on a fix.

Again, much appreciated.

@akai-katto
Copy link
Owner

akai-katto commented Jan 10, 2023

I found the source of the behavior. Expect a fix out tonight.

@akai-katto
Copy link
Owner

akai-katto commented Jan 10, 2023

@DCGYT
Copy link
Author

DCGYT commented Jan 17, 2023

@akai-katto The issue was fixed, thank you very much, but still the same issues with noise and everything else.

Is there any documentation on everything yaml does because I don't understand it much, or if more experimental settings can be added to try to track down where the errors are coming from?

@akai-katto
Copy link
Owner

Can you be more specific with your request?

  1. "Quality coefficient" refers to how "alike" two blocks can be for them to be considered a "valid block match".

  2. "Tile Size" is the setting that waifu2x-ncnn-vulkan uses in order to "tile across" the image. Larger means it'll sample more pixels, causing the distortion that you notice, while smaller is slower, but will cause less distortion.

Do you have any other questions? I'd be happy to answer, sorry if I haven't been the most direct.

@DCGYT
Copy link
Author

DCGYT commented Jan 17, 2023

@akai-katto I am referring to the "yaml", which I don't understand very well how it works. I would like to see if by modifying some parameters I can reduce the bugs. Also if there is a possibility to add more experimental parameters to see if it somehow changes something to the video. Because I haven't seen that it has been modified in the last versions.

On the subject of distortion, in my opinion, I see that it is the same only in a smaller grid, the noise is always the same.

@akai-katto
Copy link
Owner

@DCGYT are you referring to output_options.yaml?

@DCGYT
Copy link
Author

DCGYT commented Jan 18, 2023

@akai-katto Yes, I would like the noise issue to be completely solved, because when applying sharpening filters it is too noticeable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants