-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Click Events on Child Items Not Firing - iOS (Desktop Browsers working as intended) #38
Comments
Ran into the same issue |
Related to kenwheeler/slick#412 if we upgrade the slick version we are using here, it would fix |
I've run into the same issue. On desktop, onClick events work as expected, but on mobile (whether in the chrome simulator or on an actual phone) onClick events don't go through. Thinking that this may have been related to facebook/react#1169, I added cursor: pointer on all clickable elements, but that did not solve the problem. |
@yankrasny Can you make a gist or jsfiddle? From which I can reporduce this issue? It will help a lot. |
@vramana sure, I'll try to get you an example later today. Thanks for the quick response. |
Hey @vramana, here are the jsfiddles for desktop and mobile. Desktop: https://jsfiddle.net/yankrasny/hug2f0r1/6/ The behavior is to display the link that was last clicked as proof that the onClick event went through. It works on desktop but not on mobile. You'll also notice that on desktop, clicking any of the slides brings you back to the first one. I believe @haohcraft is right and this may be related to kenwheeler/slick#412. |
This is also happening for me. |
@akiran any update on this? |
@stevemckenzie Can you test the fix in 0.6.1 version |
Just tested version 0.6.1 and the issue appears to be fixed. Thank you! |
Thank you @akiran ! This definitely fixes the ability to touch links in slides. I thought this was going to fix the automatically scrolling back to the first item when you start scrolling the page issue too but it didn't. |
@stevemckenzie Can you open a separate issue for the scrolling issue. |
how can I get version 0.6.1 with this fix? Available versions using bower are 0.5.0, 0.4.1 and 0.3.1 |
I created a github release with 0.6.4 version. Now you should be able to get it from bower |
Thank you very much! @akiran |
Slider portion works great, but any buttons that are within the panes are having their click events trapped. I attempted to turn off the swipe detection, but that also didn't allow clicks to go through. Any thoughts?
The text was updated successfully, but these errors were encountered: