Extra poll after receiving commit data #866
Merged
+26
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2m
reviewed
Aug 20, 2019
| * performance is much improved by collecting more requests/commits before performing the poll. | ||
| */ | ||
| private def requestExtraPoll(): Unit = | ||
| if (!delayedPollInFlight) { |
There was a problem hiding this comment.
I think the flag should match the method, so extraPollInFlight or requestDelayedPoll().
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Trigger a poll after receiving commit data so that the commit will be executed earlier than the scheduled poll, but still allowing more commits to arrive before the poll is made.
References
Follow-up on #862 as the "at-most-once" benchmarks showed very slow consumption when committing one message at a time.