Introduce setting for committing without backpressure #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
This is the difference between this PR and #874: ennru/alpakka-kafka@ennru:commit-and-forget...ennru:commit-and-forget-settings |
ennru
force-pushed
the
commit-and-forget-settings
branch
from
8542663 to
dde68c2
Compare
ennru
commented
Sep 3, 2019
|
I opened #882 as follow up to decide about this new feature's future, once it is merged. |
2m
reviewed
Sep 5, 2019
| @@ -0,0 +1,3 @@ | |||
| # PR #883 Committing without backpressure | |||
| # https://github.com/akka/alpakka-kafka/pull/883 | |||
| ProblemFilters.exclude[DirectMissingMethodProblem]("akka.kafka.CommitterSettings.this") | |||
There was a problem hiding this comment.
The mima exclusion files can be merged to one.
ennru
force-pushed
the
commit-and-forget-settings
branch
from
c2b1a77 to
5382e56
Compare
ennru
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Explore an API to send commits to Kafka without waiting for an acknowledgement.
This PR is an alternative to #874. This alternative uses a new flag in
CommitterSettingsto enable committing without backpressure on the existingCommitterflows.References
#874 offers different factory methods to use committing without backpressure.
See #845
Changes
CommitterSettings.delivery(CommitDelivery)CommitWithoutReplymessageCommittableBatch.commitAndForgetUnrelated:
Background Context
It is not obvious why one would backpressure reading from a consumer when commits are not acknowledged by Kafka at the same rate. This new API opens for a new way of committing without waiting for the commit to get a reply from the Kafka broker.