Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API call parameters so that we can use latest version of tastypie package #165

Closed
osg74 opened this issue Mar 12, 2013 · 7 comments
Closed
Assignees
Labels

Comments

@osg74
Copy link

osg74 commented Mar 12, 2013

The latest version of tastypie has different parameters for the API calls -- we'll need to update our code to use the new parameters so that we can get the fixes included in the latest package version.

@adriancollier
Copy link
Contributor

@osgl @zzgvh is this a small issue that a fix can be quickly pushed into UAT? Or do we need to do some more heavy lifting to get this in?

@zzgvh
Copy link
Contributor

zzgvh commented Jul 2, 2013

I have code to fix this in a stash locally that I can bring back now that Cordaid's settled (for the moment). Upgrading Tastypie breaks a few of the internal methods I have overridden because the calling params signature have changed. I worked on this while doing the Cordaid hacking but realised that upgrading didn't solve the bug I was trying to squash, so I stashed the changes and kept the Tasty version. But the fixes should enable moving to 0.9.15 (or 0.9.16 if it's been released at the time) and I'd like to use that when developing the API further.

@adriancollier
Copy link
Contributor

@zzgvh did you do anything with this? I am pushing this back to 2.2.0.

@adriancollier
Copy link
Contributor

Does upgrading the API have an impact on Live Implemented Partners? We need to ensure that we communicate whenever there might be changes in the calls or responses that partners send/receive.

@zzgvh
Copy link
Contributor

zzgvh commented Sep 23, 2013

The two latest versions of Tastypie are 0.9.14 and 0.10.0. We can't currently use 0.10.0, it requires Django >= 1.5. 0.9.14 runs when defusedxml is added to the pip requirements. Haven't tested it thoroughly, but in general the API either works or not 😛 An upgrade should in no way change the outwards facing API.

@KasperBrandt
Copy link
Contributor

Tastypie upgraded in Django 1.6 upgrade

@KasperBrandt
Copy link
Contributor

Test plan

None, no work was done in this milestone, since Tastypie had already been updated in the Django upgrade.

@adriancollier adriancollier removed this from the 2.3.9 Yam milestone Jun 30, 2014
@MichaelAkvo MichaelAkvo moved this to Done in RSR Dec 8, 2022
@MichaelAkvo MichaelAkvo added this to RSR Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

5 participants