-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update API call parameters so that we can use latest version of tastypie package #165
Comments
I have code to fix this in a stash locally that I can bring back now that Cordaid's settled (for the moment). Upgrading Tastypie breaks a few of the internal methods I have overridden because the calling params signature have changed. I worked on this while doing the Cordaid hacking but realised that upgrading didn't solve the bug I was trying to squash, so I stashed the changes and kept the Tasty version. But the fixes should enable moving to 0.9.15 (or 0.9.16 if it's been released at the time) and I'd like to use that when developing the API further. |
@zzgvh did you do anything with this? I am pushing this back to 2.2.0. |
Does upgrading the API have an impact on Live Implemented Partners? We need to ensure that we communicate whenever there might be changes in the calls or responses that partners send/receive. |
The two latest versions of Tastypie are 0.9.14 and 0.10.0. We can't currently use 0.10.0, it requires Django >= 1.5. 0.9.14 runs when defusedxml is added to the pip requirements. Haven't tested it thoroughly, but in general the API either works or not 😛 An upgrade should in no way change the outwards facing API. |
Tastypie upgraded in Django 1.6 upgrade |
Test planNone, no work was done in this milestone, since Tastypie had already been updated in the Django upgrade. |
The latest version of tastypie has different parameters for the API calls -- we'll need to update our code to use the new parameters so that we can get the fixes included in the latest package version.
The text was updated successfully, but these errors were encountered: