Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Clearing a bookmark label text through the Toggle Labeled command leaves the leading spaces in the bookmark #344

Closed
cateyes99 opened this issue Oct 29, 2020 · 0 comments
Assignees
Labels
Milestone

Comments

@cateyes99
Copy link

Environment/version

  • Extension version: 11.4.0
  • VSCode version: 1.50.1
  • OS version: Windows 10 Enterprise

Steps to reproduce
I saw #320 update in the latest release 11.4.0. So i gave a try. And found:

  1. Add a new bookmark on a line which has leading spaces, i.e., the below one has some spaces at the beginning before some text ...
    image
  2. In the BOOKMARKS: EXPLORER, it looks like. All good.
    image
  3. Add a bookmark label, say aaa, to the bookmark.
  4. Now through the Toggle Labeled command from VSCode's Command Palette, clear the text aaa in the input box. Then found the bookmark on the BOOKMARKS: EXPLORER looks like this:
    image

Note: If i clear the bookmark label through the Edit Label from the BOOKMARKS: EXPLORER instead, as a result the bookmark in BOOKMARKS: EXPLORER will look normal as in 2, unlike in 4.

Interestingly, I tested the behaviours in the previous versions up to 11.0.0. Turn out that those old versions they've already support clearing bookmark label through the Edit Label from the BOOKMARKS: EXPLORER.

Furthermore, version 11.0.0 not just supports this through the Edit Label but also supports it through the Toggle Labeled command from VSCode's Command Palette already and doesn't have this bug 👀 .

@cateyes99 cateyes99 added the bug label Oct 29, 2020
@cateyes99 cateyes99 changed the title [BUG] - Clearing a bookmark label text through the Toggle Labeled command leaves the leading spaces not being removed in the bookmark [BUG] - Clearing a bookmark label text through the Toggle Labeled command leaves the leading spaces in the bookmark Oct 29, 2020
@alefragnani alefragnani added this to the 11.5.0 milestone Oct 30, 2020
@alefragnani alefragnani self-assigned this Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants