Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Ctrl + Return to open the selected project in new window #76

Closed
djhojd opened this issue Dec 22, 2016 · 8 comments
Closed

Make Ctrl + Return to open the selected project in new window #76

djhojd opened this issue Dec 22, 2016 · 8 comments
Labels
depends on (in coma) Depends on issues from VS Code, but that issue is not planned/has no update more than year depends on Depends on issues from VS Code enhancement

Comments

@djhojd
Copy link

djhojd commented Dec 22, 2016

Hi guys,

I'm aware of the new feature (and thank you!) that will open the select project into a new window by using Project Manager: List Projects to Open in New Window or the setting projectManager.openInNewWindow.

What I think would be nice (don't know if VS Code API even let's you) is to have only one Project Manager: List Projects to Open and after you select the project you want to be able to use Enter to open in current window and (let's say) Shift+Enter to open in a new window. Of course this would mean that you will need a projectManager.openInNewWindow which if set to false will do the above but if set to true will switch the above behavior.

What do you think?

@alefragnani
Copy link
Owner

Hi @djhojd ,

When I created the new command, I did take a look on how to accomplish the Ctrl + /Shift + option, but didn't find any API to handle that.

You have this in some core commands, like in Open Recent or when using Ctrl + P for opening files (which will open in new tab), but It appeared to be something handled in low level, not publicly available.

I really like the idea and maybe the API has been made public. I will take a look 👍

@alefragnani alefragnani added enhancement depends on Depends on issues from VS Code labels Dec 28, 2016
@alefragnani
Copy link
Owner

Depends on microsoft/vscode#18064

@alefragnani alefragnani changed the title Shortcut that will always open the selected project in a new window Make Ctrl + Return to open the selected project in new window May 20, 2017
@alefragnani
Copy link
Owner

Hi @djhojd @rockingskier ,

Last week I decided to "re-focus" on some of my extensions, and I'll start to plan milestones for each of them. But this "re-focus" will be based on community feedback/support.

I'm closing this issue because the VS Code issue that it depends on, has no update from VS Code team members for more than an year. It is not planned on any Milestone, so it appears it will not be released soon. I'm subscribed to that issue, so if/when it is closed, I'll be notified.

Thank you

@alefragnani alefragnani added the depends on (in coma) Depends on issues from VS Code, but that issue is not planned/has no update more than year label Mar 21, 2019
@jabacchetta
Copy link

jabacchetta commented Jul 18, 2019

For anyone coming to this issue, please remember to "thumbs up" the open VSCode issue linked above so that it is more likely to get on their radar.

@alefragnani Reopening this issue might help to direct more attention to the open VSCode issue. Just a thought, anyway. But definitely understand wanting to keep this extension's open issues cleaned up.

@alexrussell
Copy link

Looks like you might be able to go part way towards this with the new alternativeAcceptSelectedQuickOpenItem command (see bottom of linked section, just above this section)?

But as I said in microsoft/vscode#18064 it's not clear whether you as an extension author can use this functionality or not.

@alefragnani
Copy link
Owner

Hi @alexrussell ,

I’ll take a look at the latest API in the weekend, but my initial feeling is that’s only available for the open Symbol picker, as you commented.

Stay tuned

@alexrussell
Copy link

Yup, looking very briefly into the QuickPick API I couldn't see how VS Code can tell the extension whether the alternative accept was used. The release notes also didn't seem to mention anything in extension development as far as I could see.

But it'd be interesting to see how the files/symbols picker does it, being as it presumably uses the same public APIs as extensions...?

@alefragnani
Copy link
Owner

No, it does not uses the same public API, unfortunately.

BTW, there are other limitations in the public API. For instance, it does not allow groups/sections like you see when you open the Go to Symbolcommand. I've opened an issue about this in 2016, but it is still open microsoft/vscode#11468 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depends on (in coma) Depends on issues from VS Code, but that issue is not planned/has no update more than year depends on Depends on issues from VS Code enhancement
Projects
None yet
Development

No branches or pull requests

4 participants