Skip to content
This repository has been archived by the owner on Jan 16, 2023. It is now read-only.

Make compatible with 'React v15.5.0' #67

Merged
merged 12 commits into from
Jun 28, 2017
Merged

Make compatible with 'React v15.5.0' #67

merged 12 commits into from
Jun 28, 2017

Conversation

MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented May 11, 2017

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 99.184% when pulling a1e257f on MichaelDeBoey:react-15.5 into 3046fc0 on alexcurtis:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 99.184% when pulling b3a284d on MichaelDeBoey:react-15.5 into 3046fc0 on alexcurtis:master.

@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented May 11, 2017

@alexcurtis The coverage decreased with 0.3%, but I haven't added anything new, so I think we could pass this one...?

toggle: (props) => {
return {
animation: { rotateZ: props.node.toggled ? 90 : 0 },
toggle: ({node: toggled}) => ({

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @MichaelDeBoey . I think here is a little mistake. The correct code should be:

 export default {
    toggle: ({node}) => ({
        animation: {rotateZ: node.toggled ? 90 : 0},
        ...

Copy link
Contributor Author

@MichaelDeBoey MichaelDeBoey May 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh! 😓
I meant to write toggle: ({node: {toggled}}) => { 😓

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 99.184% when pulling a0aedac on MichaelDeBoey:react-15.5 into 3046fc0 on alexcurtis:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 99.184% when pulling 7dacf54 on MichaelDeBoey:react-15.5 into 3046fc0 on alexcurtis:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 99.184% when pulling 14b593c on MichaelDeBoey:react-15.5 into 3046fc0 on alexcurtis:master.

@kazazor
Copy link

kazazor commented May 18, 2017

I would love to see this PR merged :)

@MichaelDeBoey
Copy link
Contributor Author

@alexcurtis I think we're all waiting for this one... 🙂

@alexcurtis
Copy link
Collaborator

alexcurtis commented Jun 2, 2017

@MichaelDeBoey Would you be up for helping me out as a project contributor / maintainer?
Your work looks great and I'm swamped and could really do with a hand.

@MichaelDeBoey
Copy link
Contributor Author

@alexcurtis Yeah sure I'd like to help you out. Don't know if I have the time to be a real maintainer, but I can defo help you out if you want. 🙂

@travisdahl
Copy link

+1 to merge this :)

@MichaelDeBoey
Copy link
Contributor Author

@alexcurtis I think the best is to merge this one for now, so everybody can take advantage of the React v15.5 compatibility. 🙂
You can PM me for settling the maintainer thing 😉

@azizali
Copy link

azizali commented Jun 15, 2017

Any update on the merge @alexcurtis

@MichaelDeBoey
Copy link
Contributor Author

@alexcurtis Any news on this one? 🙂

@igor-dv
Copy link
Contributor

igor-dv commented Jun 28, 2017

@alexcurtis @MichaelDeBoey
Hey, Is there a plan to merge the fix in the nearest future ?
We are considering to use react-treebeard in the Storybook. Here

@MichaelDeBoey
Copy link
Contributor Author

@igor-dv I can merge it as soon as @alexcurtis will give me the correct permissions to do so 🙂

@MichaelDeBoey MichaelDeBoey merged commit 832d812 into storybook-eol:master Jun 28, 2017
@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Jun 28, 2017

@alexcurtis If you give me permission to publish this one to npm I'll update the package.json and release it 🙂
You can always contact me to discuss further transfer of code btw 😉

@igor-dv
Copy link
Contributor

igor-dv commented Jul 2, 2017

Hey, @MichaelDeBoey , did you manage to run the example after the changes ?

After the transpilation of the src/index.js to lib/index.js it looks like this:

//....

exports.default = {
    Treebeard: _treebeard2.default,
    decorators: _decorators2.default,
    animations: _animations2.default,
    theme: _default2.default
};

in example there is an import :

import {Treebeard, decorators} from '../src/index';

which doesn't work anymore.. because of the default export (it returns object)

when changing the src/index.js to the named export:

//....

export {
    Treebeard,
    decorators,
    animations,
    theme
};

It starts working again.

@MichaelDeBoey
Copy link
Contributor Author

@igor-dv I try to look at this one today 🙂

@emmagoldblum
Copy link

emmagoldblum commented Jul 7, 2017

Hello, when are you going to update the lib with this commit on npm ? :) @alexcurtis @MichaelDeBoey

@igor-dv
Copy link
Contributor

igor-dv commented Jul 7, 2017

Since this repo is a bit abandoned by its owner, I've forked it to here. So you can meanwhile use it with the latest changes.. The package in npm is called storybook-react-treebeard.

@MichaelDeBoey
Copy link
Contributor Author

@emmagoldblum I'd love to update the lib on npm too, but I can only do so when @alexcurtis gives me the right permissions
Till that time I can only update the repo here on Github 😕

@alexcurtis
Copy link
Collaborator

@MichaelDeBoey please send me your npm username and ill add you as an owner

@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Jul 8, 2017

@alexcurtis Where should I send it to? (I have some other questions also btw)

@alexcurtis
Copy link
Collaborator

@MichaelDeBoey I've sent you an email to your public email address ([email protected])

@ibiBgOR
Copy link

ibiBgOR commented Jul 14, 2017

Any news on this? @alexcurtis @MichaelDeBoey

@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Jul 14, 2017

@ibiBgOR I think I'll have some good news tonight 😉

@MichaelDeBoey
Copy link
Contributor Author

v2.0.0is released as of now! 🙂

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
10 participants