-
Notifications
You must be signed in to change notification settings - Fork 295
Make compatible with 'React v15.5.0' #67
Make compatible with 'React v15.5.0' #67
Conversation
@alexcurtis The coverage decreased with 0.3%, but I haven't added anything new, so I think we could pass this one...? |
src/themes/animations.js
Outdated
toggle: (props) => { | ||
return { | ||
animation: { rotateZ: props.node.toggled ? 90 : 0 }, | ||
toggle: ({node: toggled}) => ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @MichaelDeBoey . I think here is a little mistake. The correct code should be:
export default {
toggle: ({node}) => ({
animation: {rotateZ: node.toggled ? 90 : 0},
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doh! 😓
I meant to write toggle: ({node: {toggled}}) => {
😓
I would love to see this PR merged :) |
@alexcurtis I think we're all waiting for this one... 🙂 |
@MichaelDeBoey Would you be up for helping me out as a project contributor / maintainer? |
@alexcurtis Yeah sure I'd like to help you out. Don't know if I have the time to be a real maintainer, but I can defo help you out if you want. 🙂 |
+1 to merge this :) |
@alexcurtis I think the best is to merge this one for now, so everybody can take advantage of the |
Any update on the merge @alexcurtis |
@alexcurtis Any news on this one? 🙂 |
@alexcurtis @MichaelDeBoey |
@igor-dv I can merge it as soon as @alexcurtis will give me the correct permissions to do so 🙂 |
@alexcurtis If you give me permission to publish this one to npm I'll update the package.json and release it 🙂 |
Hey, @MichaelDeBoey , did you manage to run the example after the changes ? After the transpilation of the //....
exports.default = {
Treebeard: _treebeard2.default,
decorators: _decorators2.default,
animations: _animations2.default,
theme: _default2.default
}; in example there is an import : import {Treebeard, decorators} from '../src/index'; which doesn't work anymore.. because of the when changing the //....
export {
Treebeard,
decorators,
animations,
theme
}; It starts working again. |
@igor-dv I try to look at this one today 🙂 |
Hello, when are you going to update the lib with this commit on npm ? :) @alexcurtis @MichaelDeBoey |
Since this repo is a bit abandoned by its owner, I've forked it to here. So you can meanwhile use it with the latest changes.. The package in npm is called |
@emmagoldblum I'd love to update the lib on npm too, but I can only do so when @alexcurtis gives me the right permissions |
@MichaelDeBoey please send me your npm username and ill add you as an owner |
@alexcurtis Where should I send it to? (I have some other questions also btw) |
@MichaelDeBoey I've sent you an email to your public email address ([email protected]) |
Any news on this? @alexcurtis @MichaelDeBoey |
@ibiBgOR I think I'll have some good news tonight 😉 |
|
velocity-react
&radium
prop-types
package instead ofReact.PropTypes
(closes Use 'prop-types' package instead of React.PropTypes #63)React.createClass
in tests (closes Use 'create-react-class' package instead of React.createClass #64)react-dom/test-utils
package instead ofreact-addons-test-utils
in tests (closes Use 'react-dom/test-utils' package instead of 'react-addons-test-utils' #65)reactid
isn't used anymore sinceReact v15.0
)