Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why 'CI' in env forces color support? #79

Closed
alexeyten opened this issue Sep 3, 2024 · 3 comments
Closed

Why 'CI' in env forces color support? #79

alexeyten opened this issue Sep 3, 2024 · 3 comments

Comments

@alexeyten
Copy link

https://github.com/alexeyraspopov/picocolors/blob/main/picocolors.js#L9

I'm confused why setting CI env (with literally any value) should mean that there is color support?
@ai
Copy link
Contributor

ai commented Sep 3, 2024

Because isTTY is broken on GitHub Actions

@alexeyten
Copy link
Author

OK, thank you.

@alexeyraspopov
Copy link
Owner

I'm willing to switch to isTTY again to fix other issues, so I hope check for CI flag is sufficient enough. See #87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ai @alexeyten @alexeyraspopov