Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Romanian translation #506

Closed
dutzhk opened this issue Sep 13, 2018 · 3 comments
Closed

Romanian translation #506

dutzhk opened this issue Sep 13, 2018 · 3 comments
Milestone

Comments

@dutzhk
Copy link

dutzhk commented Sep 13, 2018

Hello, I've made a romanian translation in POEditor.

I do not know how to compile a version with romanian language in it (or just temporary change another language in to romanian one, replace a public.properties file) in order to live test it and make the finishing touches as typos or formatting errors are way easier to spot this way. Just want to make sure the correct translation is in order for the final version.
Also, are diacritical signs supported?

It it possible to compile it for me or send me in the right direction to do it myself?

Thank you!

@dutzhk
Copy link
Author

dutzhk commented Sep 14, 2018

I did not know if to edit my original post or write a new comment. I'd rather write a new comment as I managed to resolve this on my own after a couple of hours.
Google + Alf.io readme are my friends :)

Made a new .war file from source using Gradle, in which I changed public.properties and admin.properties files to the ones translated. Temporarily changed EN language to RO, leaving the locale variable to en in order for this to work as there is no romanian language defined yet.
Also I don't see why diacritical signs could not be supported; it was a question without much logic.

I will test the translation thoroughly for a couple of days and update it in POEditor and hope that in the future it will be added to alfio.

This can be closed as it is solved :)

Cheers!

@cbellone
Copy link
Member

cbellone commented Oct 2, 2018

Hi @dutzhk ,
Thank you for your contribution! :-)

How is the test going so far? Are you happy with the translation status?
If yes, we'll add support for Romanian and release it with the next version (no ETA yet). Please let me know

Celestino

@cbellone cbellone added this to the 2.0-M1 milestone Nov 5, 2018
@syjer
Copy link
Member

syjer commented Dec 2, 2018

The translations has been integrated in commit 0d5b71f .

@syjer syjer closed this as completed Dec 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants