Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): bump peer to React 18 #1385

Merged
merged 2 commits into from
May 17, 2022
Merged

feat(deps): bump peer to React 18 #1385

merged 2 commits into from
May 17, 2022

Conversation

shortcuts
Copy link
Member

Summary

Bumps the React peer dependency to React 18.

In this PR we also:

  • Add Cypress tests to the CI
  • Update the current Jest tests to avoid act warnings
  • Remove unused dependencies

Draft until I do more tests locally

@shortcuts shortcuts self-assigned this May 8, 2022
@netlify
Copy link

netlify bot commented May 8, 2022

Deploy Preview for docsearch canceled.

Name Link
🔨 Latest commit 42a0ce3
🔍 Latest deploy log https://app.netlify.com/sites/docsearch/deploys/628377240ee836000939a062

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 8, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 42a0ce3:

Sandbox Source
Vanilla Configuration

@shortcuts shortcuts marked this pull request as ready for review May 11, 2022 10:07
Copy link
Contributor

@bodinsamuel bodinsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

cypress/support/commands.ts Outdated Show resolved Hide resolved
@shortcuts shortcuts force-pushed the feat/react-18-peer branch from 2fddd35 to 42a0ce3 Compare May 17, 2022 10:21
@shortcuts shortcuts merged commit eb372f2 into next May 17, 2022
@shortcuts shortcuts deleted the feat/react-18-peer branch May 17, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants