fix: use spans inside button tag instead of divs #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
reviewed
Feb 1, 2021
| {...props} | ||
| ref={ref} | ||
| > | ||
| <div className="DocSearch DocSearch-Button" {...props} ref={ref}> | ||
| <div className="DocSearch-Button-Container"> |
There was a problem hiding this comment.
this should be moved to a span instead and the button stays (I think)
There was a problem hiding this comment.
Yes, we are more and more confident with this button tag.
There was a problem hiding this comment.
Agree, it makes sense, replaced divs with spans.
lex111
changed the title
Shipow
approved these changes
Feb 2, 2021
Haroenv
approved these changes
Feb 2, 2021
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
At the moment there is the following HTML issue related to the incorrect use of the
buttontag:I suggest replacing the
buttonwith a regulardivelement.Result
According to the validator (https://validator.w3.org/nu/#textarea), the error has been fixed.
cc @francoischalifour