This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
fix(formatHit): fixed npe, not all hits have a country #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,6 +2,9 @@ import findCountryCode from './findCountryCode.js'; | |||
| import findType from './findType.js'; | |||
|
|
|||
| function getBestHighlightedForm(highlightedValues) { | |||
| if (highlightedValues.length === 0) { | |||
There was a problem hiding this comment.
Do the API sometimes send _highlightResult.locale_names = []?
There was a problem hiding this comment.
No we don't but I prefer having too much safety checks
There was a problem hiding this comment.
Ok, I would remove it then. I feel like everytime we do this, it leads to defensive programming, dead code + FUD (= we will keep this code, just in case)
|
Add tests pleaaaaase :p |
Yes sorry about that, has been done quickly to fix the broken latest version. |
|
added one in #293 |
vvo
added a commit
that referenced
this pull request
Jul 25, 2016
* test(formatHit): add test when no country linked with #292 * chore(formatHit): remove dead code
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #291