This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
feat(postcodes): expose postcodes array in suggestions #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphi
suggested changes
Oct 30, 2018
|
|
||
| Examples: | ||
|
|
||
| - `["94102","94103","94104",...]` |
There was a problem hiding this comment.
Now is:
which was the way I felt it rendered the best
| - city | ||
| - postcode | ||
| - county | ||
| - administrative |
| @@ -83,7 +121,8 @@ export default function formatHit({ | |||
| lat: hit._geoloc.lat, | |||
| lng: hit._geoloc.lng, | |||
| }, | |||
| postcode: hit.postcode && hit.postcode[0], | |||
| postcode, | |||
| postcodes: hit.postcode ? hit.postcode : undefined, | |||
There was a problem hiding this comment.
Shouldn't it be postcodes: hit.postcodes ? hit.postcodes : undefined,?
There was a problem hiding this comment.
The raw response field for the postcode array is postcode, so it's not a typo!
JonathanMontane
force-pushed
the
feat/postcodes
branch
from
a1fcf7c to
d796cd4
Compare
|
Let me know what you think of the formatting changes @raphi |
raphi
approved these changes
Oct 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR exposes the postcodes array in the suggestion object.
It now also returns the best matching postcode as
postcodewhen possible.the postcode field is now also included in the highlight object.
Result
exposes the postcodes field
updates tests to include postcodes array
updates the documentation to include section about postcodes
update landing formatting with new postcodes object (truncated for readability)