Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

fix(set-val-icon): show correct icon when calling setVal #760

Merged
merged 1 commit into from
Apr 1, 2019
Merged

fix(set-val-icon): show correct icon when calling setVal #760

merged 1 commit into from
Apr 1, 2019

Conversation

JonathanMontane
Copy link
Contributor

closes #663

Fixes

  • fix(set-val-icon): shows clear icon when calling setVal with non-empty string and pin icon when calling with empty string.
  • fix(raw-loader): createAutoCompleteDataset now uses es6 module syntax for css.

@JonathanMontane JonathanMontane self-assigned this Apr 1, 2019
@JonathanMontane JonathanMontane requested a review from raphi April 1, 2019 12:36
raphi
raphi approved these changes Apr 1, 2019
View reviewed changes
Copy link
Contributor

@raphi raphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JonathanMontane JonathanMontane merged commit 3050e15 into master Apr 1, 2019
@JonathanMontane JonathanMontane deleted the fix/set-val-icon branch April 1, 2019 14:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@raphi raphi raphi approved these changes

Assignees

@JonathanMontane JonathanMontane

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improvement: Show clear button with placesAutocomplete.setVal()
2 participants
@JonathanMontane @raphi