feat(UserAgent): introduce addAlgoliaAgent method #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkrugg
commented
Apr 8, 2019
| @@ -66,6 +68,10 @@ class AlgoliaAnalytics { | |||
| _userHasOptedOut: boolean; | |||
| _cookieDuration: number; | |||
|
|
|||
| // user agent | |||
| _ua: string = ""; | |||
There was a problem hiding this comment.
_ua is the current name in the search client too
https://github.com/algolia/algoliasearch-client-javascript/blob/ead86654beb7bc5215bb8ff66d4c951637190a10/src/AlgoliaSearchCore.js#L175
This introduces a addAlgoliaAgent method that can be also found in the
search client.
```ts
aa('addAlgoliaAgent', 'a random string')
```
tkrugg
force-pushed
the
feat/user-agent-1
branch
from
ef34f57 to
ac4a064
Compare
Haroenv
reviewed
Apr 8, 2019
Haroenv
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a addAlgoliaAgent method that can be also found in the
search client.