feat(sendEvent): return the value of the request function #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing request functions return undefined, so this isn't a breaking change, but this allows you to have a custom requester you can wait on (e.g. fetch). fixes #199
eunjae-lee
approved these changes
Feb 13, 2020
tkrugg
requested changes
Feb 14, 2020
There was a problem hiding this comment.
Hey @Haroenv, I understand the intention but this ineffective if you don't change the signature of requestFn and maybe even its implementations:
https://github.com/algolia/search-insights.js/blob/master/lib/utils/request.ts#L1
Also it would be worth adding a test checking we indeed return whatever requestFn returned, because if someone is relying on it, we'd like to detect when it's gone or stopped working
|
Don’t need to change the implementations, since that’s a breaking change, but this is for a custom requestFn to which you return something. Can add a test |
tkrugg
approved these changes
Feb 14, 2020
tkrugg
reviewed
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing request functions return undefined, so this isn't a breaking change, but this allows you to have a custom requester you can wait on (e.g. fetch).
fixes #199