Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): make eventName required #275

Merged
merged 2 commits into from
Jul 26, 2021
Merged

fix(types): make eventName required #275

merged 2 commits into from
Jul 26, 2021

Conversation

eunjae-lee
Copy link
Contributor

Summary

This PR adds eventName to InsightsSearchConversionEvent. It was missing.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 26, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 64987d0:

Sandbox Source
Vanilla Configuration

@eunjae-lee eunjae-lee requested review from a team, tkrugg and shortcuts and removed request for a team July 26, 2021 12:24
Haroenv
Haroenv approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't see any others with it missing :)

@tkrugg
Copy link
Contributor

tkrugg commented Jul 26, 2021 •
edited
Loading

We should now set it as always required in InsightsEvent: https://github.com/algolia/search-insights.js/blob/master/lib/_sendEvent.ts#L8

@eunjae-lee
Copy link
Contributor Author

We should now set it as always required in InsightsEvent: master/lib/_sendEvent.ts#L8

good catch! 64987d0

@eunjae-lee eunjae-lee changed the title fix(types): add eventName to InsightsSearchConversionEvent fix(types): make eventName required Jul 26, 2021
@eunjae-lee eunjae-lee merged commit 04ad058 into master Jul 26, 2021
@eunjae-lee eunjae-lee deleted the fix/type-conversion branch July 26, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkrugg tkrugg tkrugg approved these changes

@Haroenv Haroenv Haroenv approved these changes

@shortcuts shortcuts shortcuts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eunjae-lee @tkrugg @Haroenv @shortcuts