Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pass custom credentials as additional arguments of insights methods (v2) #399

Merged
merged 8 commits into from
Mar 3, 2023
Merged

feat: pass custom credentials as additional arguments of insights methods (v2) #399

merged 8 commits into from
Mar 3, 2023

Conversation

dhayab
Copy link
Member

@dhayab dhayab commented Feb 27, 2023

See #398

@dhayab dhayab mentioned this pull request Feb 27, 2023
Closed
@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 27, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f85623d:

Sandbox Source
Vanilla Configuration

@dhayab dhayab requested review from Haroenv and sarahdayan February 27, 2023 17:44
@dhayab dhayab marked this pull request as draft February 28, 2023 13:13
dhayab
dhayab commented Mar 1, 2023
View reviewed changes
@dhayab dhayab marked this pull request as ready for review March 1, 2023 17:06
@dhayab dhayab requested a review from benhinchley March 1, 2023 17:06
@dhayab dhayab changed the title feat: allow credentials to be set in event payload (v2) feat: pass custom credentials as additional arguments of insights methods (v2) Mar 2, 2023
Haroenv
Haroenv reviewed Mar 2, 2023
View reviewed changes
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

sarahdayan
sarahdayan approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@sarahdayan sarahdayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Can you also update the README?

@dhayab dhayab merged commit 3f66ff4 into v2 Mar 3, 2023
@dhayab dhayab deleted the feat/override-credentials-per-event-v2 branch March 3, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahdayan sarahdayan sarahdayan approved these changes

@Haroenv Haroenv Haroenv approved these changes

@benhinchley benhinchley Awaiting requested review from benhinchley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhayab @sarahdayan @Haroenv