Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(userToken): generate in-memory anonymous user tokens by default #441

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

dhayab
Copy link
Member

@dhayab dhayab commented Apr 18, 2023

This PR introduces a new initialization parameter: anonymousUserToken. This boolean (set to true by default) generates an in-memory anonymous user token which is sent with every Insights event.

See FX-2303 for more information.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 18, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cbe7131:

Sandbox Source
Vanilla Configuration

@dhayab dhayab requested review from a team, FabienMotte and aymeric-giraudet and removed request for a team April 18, 2023 16:17
@dhayab dhayab marked this pull request as draft April 18, 2023 16:22
@dhayab dhayab force-pushed the feat/anonymous-user-token branch from 1d3c527 to 94cd97a Compare April 19, 2023 09:07
@dhayab dhayab force-pushed the feat/anonymous-user-token branch from 94cd97a to ffdc25c Compare April 19, 2023 09:10
@dhayab dhayab marked this pull request as ready for review April 19, 2023 09:11
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on the fence about the anon- prefix, but it's not blocking

@Haroenv Haroenv changed the title feat: generate in-memory anonymous user tokens by default feat(userToken): generate in-memory anonymous user tokens by default Apr 20, 2023
@Haroenv Haroenv merged commit 161c933 into v2 Apr 20, 2023
@Haroenv Haroenv deleted the feat/anonymous-user-token branch April 20, 2023 15:03
@francoischalifour
Copy link
Member

It's really confusing that this new anonymousUserToken param is a boolean while userToken is a string.

benhinchley pushed a commit that referenced this pull request Dec 4, 2023
Events are sent again by default even without setting a userToken nor
using the cookie, since #441.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants